This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
[FRNT-507] Implement data table #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatinacher
force-pushed
the
feat/FRNT-507-implement-data-table
branch
from
b39612a to
3bcd4d1
Compare
sergeysova
suggested changes
Jun 7, 2021
ainursharaev
reviewed
Jun 7, 2021
В задаче нужно было сделать только DataTable без компонента фильтрации, в дальнейшем как реализуем сам компонент можно будет заменить заглушку Filter. |
tatinacher
force-pushed
the
feat/FRNT-507-implement-data-table
branch
3 times, most recently
from
6f5e883 to
5ee4d59
Compare
tatinacher
force-pushed
the
feat/FRNT-507-implement-data-table
branch
from
5ee4d59 to
7ec29b8
Compare
rchubarkin
reviewed
Jun 16, 2021
sergeysova
previously requested changes
Jun 17, 2021
tatinacher
force-pushed
the
feat/FRNT-507-implement-data-table
branch
2 times, most recently
from
0dbfd2f to
258a85d
Compare
tatinacher
force-pushed
the
feat/FRNT-507-implement-data-table
branch
from
258a85d to
19df318
Compare
Irinaristova
reviewed
Jul 6, 2021
| } | ||
|
|
||
| export const RangeCell: React.FC<RangeProps> = ({ value, placeholder }) => ( | ||
| <span> |
There was a problem hiding this comment.
мб тут лучше семантичные теги использовать, а не span
There was a problem hiding this comment.
мб тут лучше семантичные теги использовать, а не span
Это же содержимое ячейки, там должен быть инлайн-текст, нет?
There was a problem hiding this comment.
@Irinaristova RangeCell это как бы пример того, что будет на проекте, он не включен в экспорты
added 5 commits
July 13, 2021 16:57
* feat(docs): add configurators (+ color configurator) * style(docs): fix spaces * style(icons): format * style: lint styles * chore: add lint:style:fix command * perf(configurators): replace heavy libraries * [FRNT-562] add icon component (#163) * add icon component * fix * fix naming * fix usage * fix usage * [FRNT-559] add toast weight (#165) * add toast weight * fix chip and button usage * fix toast styles * [FRNT-564] Implement color palette fabrics (#162) * feat: implement color palette fabrucs * refactor: remame variable Co-authored-by: Шараев Айнур Раильевич <mr.sharaevainur@yandex.ru> * [FRNT-568] add font stacks (#153) * feat: add system-ui as a fallback font, add a font-weight vars * feat: move font-stacks to a separate file * refactor: remove font-weight, rename system font-stack * refactor: rebase and format * [FRNT-560] add weight to button-icon (#164) * add weight to button-icon * add goast styles * fix icon-button styles * [FRNT-396] Rewrite data selectors (#150) * fix: rewrite data-selector, fix grammar * feat: write styleguide for data-attribute * update Styleguide Co-authored-by: Ira <i.aristova@opends.tech> * [FRNT-520] Rewrite tooltip (#129) * chore: bump version (#169) * feat(docs): add configurators (+ color configurator) * style(docs): fix spaces * feat(docs): add white priority to configurators * refactor(configurators): change layout and color * chore(deps): update lock * fix(configurators): hardcoded configurator name * refactor(configurators): remove unused data-attribute * refactor(configurators): replace transparency parrent with svg * refactor(configurators): styling * style(configurators): remove unnecessary xmlns attribute * refactor(configurators): styling * style(configurators): remove unnecessary variables * style(configurators): remove useless code * refactor(configurator): stylesheets, simplify and add some comments * fix(configurators): add viewbox for svg * refactor(configurators): remove unused refs * feat(configurators): add scope colors * feat(configurators): limit the height of configurator's tab * refactor(configurators): remove unused forwardRef * fix(configurators): typo Co-authored-by: Ainur <33234903+purplecandle@users.noreply.github.com> * refactor(configurators): simplify toggle state * chore(deps): sync lock * refactor(configurators): size units * fix(configurators): remove tertiary priority, add success priority Co-authored-by: Irina Aristova <38761239+Irinaristova@users.noreply.github.com> Co-authored-by: tatinacher <tatinacher@gmail.com> Co-authored-by: Шараев Айнур Раильевич <mr.sharaevainur@yandex.ru> Co-authored-by: Ainur <33234903+purplecandle@users.noreply.github.com> Co-authored-by: Ira <i.aristova@opends.tech> Co-authored-by: rchubarkin <dasasd31@gmail.com>
* style: change styling data-attributes * docs(styleguide): update information about data-attributes
* feat: implement level decrement task: FRNT-592 * fix(LevelDecrement): style inner component instead of wrapper * fix(LevelDecrement): naming * feat: implement level downgrade * fix: more specific exported global styles name * fix(lib): level downgrade better naming
* create tab ana tabbar component * fix lint styles * fix tabs styles * fix tab styles * fix shadow * fix styles * rewtire styles * update tabs styles * fix styles * update styles * add weight to tab * update tab styles * fix styles * fix styles
ainursharaev
reviewed
Aug 9, 2021
ainursharaev
previously approved these changes
Aug 9, 2021
Co-authored-by: Ainur <33234903+purplecandle@users.noreply.github.com>
Irinaristova
previously approved these changes
Aug 9, 2021
ainursharaev
approved these changes
Aug 9, 2021
Irinaristova
approved these changes
Aug 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement data table